Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): properly update async component nested in KeepAlive #11917

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

edison1105
Copy link
Member

close #11916

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (-2 B) 37.7 kB (-2 B) 34 kB (+32 B)
vue.global.prod.js 159 kB (-2 B) 57.6 kB 51.2 kB (-66 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.8 kB 18.8 kB 17.2 kB
createApp 55.3 kB 21.2 kB 19.4 kB
createSSRApp 59.3 kB 22.9 kB 20.9 kB
defineCustomElement 60 kB 22.8 kB 20.7 kB
overall 69 kB 26.3 kB 23.9 kB

Copy link

pkg-pr-new bot commented Sep 13, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11917

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11917

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11917

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11917

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11917

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11917

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11917

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11917

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11917

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11917

vue

pnpm add https://pkg.pr.new/vue@11917

commit: c32bf5d

@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Sep 13, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success failure
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105 edison1105 added ready to merge The PR is ready to be merged. ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Sep 13, 2024
@yyx990803 yyx990803 merged commit 7fe6c79 into main Sep 13, 2024
15 checks passed
@yyx990803 yyx990803 deleted the edison/fix/11916 branch September 13, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue3.5: defineAsyncComponent in keep-alive the hook onActivated is not called
3 participants