Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): inherit component in renderComponentRoot #1710

Closed
wants to merge 29 commits into from
Closed

fix(runtime-core): inherit component in renderComponentRoot #1710

wants to merge 29 commits into from

Conversation

Picknight
Copy link
Contributor

fix #1700

Picknight and others added 29 commits June 17, 2020 16:07
@Picknight
Merge pull request #1 from vuejs/master
f308054 
fetch new commit
refactor(types): simplified UnwrapRef
7d68bf7
@Picknight
Merge pull request #2 from vuejs/master
c2c73cf 
update
refactor(types): simplified UnwrapRefSimple
a455677
types(reactivity): add Iterable & Iterator
e3edce7
@Picknight
Merge pull request #3 from vuejs/master
c3f8df8 
rebase
@Picknight
Merge pull request #4 from vuejs/master
a0fc926 
fetch: rebase
test(reactivity): unwrap ref types
0915aea
refactor(computed): deprecated computedRunners
7c4bd0b
revert: refactor(computed): deprecated computedRunners
82ed85e
@Picknight
Merge pull request #5 from vuejs/master
9c7c7df 
rebase
@Picknight
Merge pull request #6 from vuejs/master
7cdcb96 
rebase
@Picknight
Merge pull request #7 from vuejs/master
716fa37 
rebase
@Picknight
Merge pull request #8 from vuejs/master
b39e2e6 
rebase
@Picknight
Merge pull request #9 from vuejs/master
0d8ad49 
rebase
@Picknight
Merge pull request #10 from vuejs/master
3d6c983 
rebase
@Picknight
Merge pull request #11 from vuejs/master
cc7d3a5 
rebase
@Picknight
Merge pull request #12 from vuejs/master
a28c860 
rebase
@Picknight
Merge pull request #13 from vuejs/master
a1f4aad 
rebase
@Picknight
Merge pull request #14 from vuejs/master
7b094d4 
rebase
@Picknight
Merge pull request #15 from vuejs/master
2e0bfd1 
rebase
@Picknight
Merge pull request #16 from vuejs/master
b4ac43a 
rebase
@Picknight
Merge pull request #17 from vuejs/master
af869e9 
rebase
@Picknight
Merge pull request #18 from vuejs/master
2bc32e9 
rebase
@Picknight
Merge pull request #19 from vuejs/master
dae483e 
rebase
fix(runtime-core): inherit component in renderComponentRoot
6ac2e42 
fix #1700
fix(runtime-core): test error
3d0247e
style(runtime-core): adjust the order
d8d8841
fix(runtime-core): test error
9067dbc
@yyx990803
Copy link
Member

See #1700 (comment)

vnode.component should only be non-null on actual component vnodes.

@yyx990803 yyx990803 closed this Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vnode.component is null, inside a custom directive's hooks, when it is used onto a Vue component
2 participants
@Picknight @yyx990803