New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-dom): avoid invoker being overridden.(#1747) #1760

Closed

zhangzhonghe wants to merge 3 commits into vuejs:master from zhangzhonghe:fix/#1747

Member

zhangzhonghe commented Aug 2, 2020

When the same method is registered as a listening method by different component, its Invoker is overridden.

zhangzhonghe added 3 commits

August 2, 2020 21:34


          fix(runtime-dom): avoid invoker being overridden.(#1747)

726e6c2


          fix(runtime-dom): change key to Element from ComponentInternalInstance.

032516c


          test(runtime-dom): add test for #1747

5c9f995

Member

yyx990803 commented Aug 3, 2020

Thanks for the PR - however, I think it's better (and easier) to cache the invoker on the element by event name instead. See 1c967fc

yyx990803 closed this

zhangzhonghe deleted the fix/#1747 branch

August 4, 2020 00:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet