Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should correctly resolve extends or mixins assets #1965

Closed
wants to merge 1 commit into from
Closed

fix: should correctly resolve extends or mixins assets #1965

wants to merge 1 commit into from

Conversation

HcySunYang
Copy link
Member

@HcySunYang HcySunYang commented Aug 26, 2020

Fix: #1963

@HcySunYang HcySunYang changed the title fix: should correctly resolve extend or mixed options fix: should correctly resolve extend or mixed assets Aug 26, 2020
@HcySunYang HcySunYang changed the title fix: should correctly resolve extend or mixed assets fix: should correctly resolve extends or mixins assets Aug 26, 2020
@yyx990803
Copy link
Member

We have to avoid mutating the original options because it may be used by other components as base for extends or as a mixin.

This regression was introduced by a75b8a2 - I originally removed components and directives from component instance to reduce memory usage, but in this case we have to add them back. But we can create them only when the component actually has mixins or extends (see 0cb7f7f)

@yyx990803 yyx990803 closed this Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inheriting components & directives
2 participants