fix(runtime-dom): clear setTimeOut #2520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangzhonghe
commented
Oct 29, 2020
| if (ended < propCount) { | ||
| end() | ||
| } | ||
| }, timeout + 1) | ||
| el.addEventListener(endEvent, onEnd) | ||
| ;(el as any)[endEvent] = onEnd |
There was a problem hiding this comment.
这里如果使用 addEventListener 会导致快速点击时注册多个 onEnd ，在动画结束时这些 onEnd 会一起被调用。
There was a problem hiding this comment.
Then the better way is to just clearTimeout before setTimeout.
| @@ -270,12 +273,12 @@ function whenTransitionEnds( | |||
| } | |||
| } | |||
| } | |||
| setTimeout(() => { | |||
| el._timeoutID = setTimeout(() => { | |||
There was a problem hiding this comment.
#2482 就是因为这个 setTimeout 没有及时清除。
|
Thanks for the PR. A cleaner fix is to simply never invoke the stale callbacks, see eaf8a67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2482