-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(compiler-sfc): bump postcss to version 8 #2649
Conversation
I am also working on #2642.😭 should we move PostCSS 8 to |
@edison1105 It seems like moving to peerDependencies does not work properly. I'll move it back to devDependencies later while keeping the |
both in "peerDependencies": {
...
"postcss": "^8.1.8"
}, "devDependencies": {
...
"postcss": "^8.1.8",
} I'm not sure whether to do this. |
I'm not sure if it makes sense adding it to both 🤔 |
The purpose of the two dependencies is different. In theory it is needed. |
Okay thanks for the hint 👍 I'll add it quickly to peerDependencies again. Actually it's not devDependencies 🤦 Sorry for confusion 🙃 |
If If my understanding is wrong, please correct me. |
Notice that currently postcss-modules still depends on PostCSS 7, so with this change installing the Vue compiler will install PostCSS 8 AND 7, unless postcss-modules is ported first. |
For those waiting for official v8 support for the purpose of |
@songololo I unlocked so you can post it 🙂 Thanks! |
This seems to be based off incomplete work I was doing in the See #2710 |
Since tailwindcss v2 is available, it would be great to be able to use it in Vue applications. Unfortunately it requires
postcss
v8+. I hope I did not break the plugins while adapting the new postcss api...fix #2642