Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(reactive) add 'shallow' propety in proxy #3008

Closed
wants to merge 3 commits into from
Closed

Fix(reactive) add 'shallow' propety in proxy #3008

wants to merge 3 commits into from

Conversation

lijingfaatcumt
Copy link

No description provided.

@posva
Copy link
Member

posva commented Jan 14, 2021

What is this fixing? I'm closing #2957 in favor of this but this needs a reproduction or test case

Are you trying to fix the same thing as #3003

@lijingfaatcumt
Copy link
Author

lijingfaatcumt commented Jan 15, 2021

What is this fixing? I'm closing #2957 in favor of this but this needs a reproduction or test case

Are you trying to fix the same thing as #3003

@posva i want add property '__v_isShallow' in a proxy object as '__v_isReadonly' because i may want to know a proxy is shallow or not, to
know if we change the deep property whether that will trigger corresponding effects running or not

@posva
Copy link
Member

posva commented Jan 15, 2021

If you don't create a boiled down repro showing the existing problem or provide test cases, this won't be able to go any further...

@lijingfaatcumt
Copy link
Author

If you don't create a boiled down repro showing the existing problem or provide test cases, this won't be able to go any further...

@posva isShallow is useful, please see #3052 , i use isShallow to separete reactive and shallowReactive

@posva
Copy link
Member

posva commented Jan 19, 2021

Okay, then I'm closing this in favor of #2851 or #3052. If you think those PR, which have tests, are missing something, please add a review. If this is unrelated, add tests and ping me so I can reopen

@posva posva closed this Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants