Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): should call hooks from chained mixins and extends #3040

Merged
merged 1 commit into from
Mar 25, 2021
Merged

fix(runtime-core): should call hooks from chained mixins and extends #3040

merged 1 commit into from
Mar 25, 2021

Conversation

HcySunYang
Copy link
Member

close: #3038

@HcySunYang HcySunYang changed the title fix(runtime-core): should call chained mixins and extends fix(runtime-core): should call hooks from chained mixins and extends Jan 18, 2021
@skirtles-code
Copy link
Contributor

It looks like callHookFromExtends and callHookFromMixins are essentially the same function, except for the loop.

Should they maybe be refactored so that the core logic isn't duplicated?

@HcySunYang HcySunYang mentioned this pull request Mar 13, 2021
Closed
@HcySunYang HcySunYang added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label Mar 19, 2021
@yyx990803 yyx990803 merged commit b58bb16 into vuejs:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The mixin.created can't work when use both extends and mixins.
3 participants
@HcySunYang @skirtles-code @yyx990803