fix(compiler-core): assert the component tag correctly #3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HcySunYang
added
🔨 p3-minor-bug
posva
reviewed
Mar 29, 2021
| @@ -672,3 +673,7 @@ function stringifyDynamicPropNames(props: string[]): string { | |||
| } | |||
| return propsNamesString + `]` | |||
| } | |||
|
|
|||
| function isComponentTag(tag: string) { | |||
| return tag[0].toLowerCase() + tag.slice(1) === 'component' | |||
There was a problem hiding this comment.
isn't it faster to do a check like
Suggested change
| return tag[0].toLowerCase() + tag.slice(1) === 'component' | |
| return tag === 'component' || tag === 'Component' |
Since it's the compiler, I think it makes more sense. Size-wise it should be pretty much the same
posva
reviewed
Mar 29, 2021
| @@ -836,6 +836,24 @@ describe('compiler: element transform', () => { | |||
| }) | |||
| }) | |||
|
|
|||
| test('capitalized version w/ static binding', () => { | |||
There was a problem hiding this comment.
I think we can just write the whole word 😆
Suggested change
| test('capitalized version w/ static binding', () => { | |
| test('capitalized version with static binding', () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #3507