Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compat): return merged data from mergedDataFn #3839

Closed
wants to merge 1 commit into from
Closed

fix(compat): return merged data from mergedDataFn #3839

wants to merge 1 commit into from

Conversation

SeregPie
Copy link

You forgot to return to. Data was always undefined if using mixins.

@SeregPie SeregPie changed the title [compat] return merged data from mergedDataFn fix(compat): return merged data from mergedDataFn May 28, 2021
@SeregPie SeregPie mentioned this pull request May 31, 2021
Closed
@LinusBorg LinusBorg added the need test The PR has missing test cases. label May 31, 2021
@LinusBorg LinusBorg linked an issue May 31, 2021 that may be closed by this pull request
[compat] component data is overwritten by mixins #3852
Closed
posva
posva requested changes May 31, 2021
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can you add a test case?

@yyx990803
Copy link
Member

Thanks for the PR! However, it is simpler to return the object from deepMergeData. See c7efb96

@yyx990803 yyx990803 closed this May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva requested changes

Assignees
No one assigned
Labels
need test The PR has missing test cases.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[compat] component data is overwritten by mixins
4 participants
@SeregPie @yyx990803 @posva @LinusBorg