feat(types): add defined emits to props #3926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Amour1688
commented
Jun 9, 2021
Amour1688
commented
|
nice |
posva
requested changes
Jun 11, 2021
Amour1688
force-pushed
the
emits-to-props
branch
from
bb51688
to
a9d458e
Compare
meteorlxy
reviewed
Jun 12, 2021
Amour1688
force-pushed
the
emits-to-props
branch
from
a9d458e
to
c68c9ca
Compare
Amour1688
commented
Jun 12, 2021
| @@ -66,7 +66,7 @@ | |||
| "lint-staged": "^10.2.10", | |||
| "minimist": "^1.2.0", | |||
| "npm-run-all": "^4.1.5", | |||
| "prettier": "~1.14.0", | |||
| "prettier": "^2.3.1", | |||
There was a problem hiding this comment.
TS template literal types that cannot be handled.
Amour1688
force-pushed
the
emits-to-props
branch
from
c68c9ca
to
4c52ad2
Compare
Closed
1 task
Amour1688
force-pushed
the
emits-to-props
branch
from
4c52ad2
to
118dba9
Compare
|
What's the status？ |
yyx990803
requested changes
Jun 20, 2021
Amour1688
force-pushed
the
emits-to-props
branch
from
118dba9
to
6347f29
Compare
posva
reviewed
Jun 21, 2021
Justineo
reviewed
Jun 21, 2021
Amour1688
force-pushed
the
emits-to-props
branch
from
6347f29
to
7a4fc07
Compare
posva
approved these changes
Jun 23, 2021
posva
changed the title
yyx990803
force-pushed
the
3.2
branch
2 times, most recently
from
6ed23f6
to
49dc2dd
Compare
yyx990803
force-pushed
the
emits-to-props
branch
from
4e379d9
to
e82f80a
Compare
|
Is this change just to fix a bug in the TSX? Props does not actually have an onClick property. This will contaminate the editor's automatic code prompt. |
haoqunjiang
added a commit
to vuejs/create-eslint-config
that referenced
this pull request
Oct 25, 2024
…vue core After all, `vuejs/core` is more of a TypeScript project than a Vue project. I feel that we really need `printWidth: 100` for templates. And `arrowParens` isn't that important. Let's use the default value. Moreover, as stated in [prettier's documentation](https://prettier.io/docs/en/options#arrow-function-parentheses), `arrowParens: "always"` is better for adding type annotations, extra arguments or default values as well as making other changes. I believe that `arrowParens: "avoid"` is set in `vuejs/core` only because it started using prettier in its 1.x era and want to avoid too drastic style changes. vuejs/core#3926 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.