refactor(componentProps): clean up code and improve types #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsn
reviewed
Oct 30, 2019
Co-Authored-By: katashin <ktsn55@gmail.com>
yyx990803
requested changes
Oct 30, 2019
| | DefaultFactory<T> | ||
| | null | ||
| | undefined | ||
| | (T extends Function ? never : T) // If type of prop is function, only allow factory function |
There was a problem hiding this comment.
I'm not sure if this makes sense. Actually it seems to break certain cases.
cuongdevjs
approved these changes
Nov 9, 2019
|
Closing as stale. Thanks for the PR still! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.