fix(runtime-core): add InferDefaults handling of array and object union types #4925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on types
This fixes an issue where `InferDefaults` fails to handle union types with base types and array or object types.
`TS2322: Type 'number' is not assignable to type '((props: Readonly<{ foo: number | number[]; }>) => number | number[]) | undefined'.`
would throw for
```ts
withDefault(
defineProps<{ foo: number | number[] }>(),
{ foo: 123 },
)
```
This adds handling of base types and array or object types separately, so that both types can exist in prop type unions.
yyx990803
reviewed
Nov 15, 2021
| { | ||
| [K in keyof Defaults]: K extends keyof Base ? NotUndefined<Base[K]> : never | ||
| } | ||
| type InferDefault<P, T> = T extends |
There was a problem hiding this comment.
The original logic seemed unnecessarily complex so I refactored it - thanks for the fix and the test case though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where
InferDefaultsfails to handle union types with base types and array or object types.TS2322: Type 'number' is not assignable to type '((props: Readonly<{ foo: number | number[]; }>) => number | number[]) | undefined'.would throw for
This adds handling of base types and array or object types separately, so that both types can exist in prop type unions.