fix(types): toRefs should not do any ref unwrapping
#4966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JensDll
commented
Nov 18, 2021
| // #2687: somehow using ToRef<T[K]> here turns the resulting type into | ||
| // a union of multiple Ref<*> types instead of a single Ref<* | *> type. | ||
| [K in keyof T]: T[K] extends Ref ? T[K] : Ref<UnwrapRef<T[K]>> | ||
| [K in keyof T]: ToRef<T[K]> | ||
| } |
There was a problem hiding this comment.
When this was added in e315d84 the type for ToRef looked different, which is why doing ToRef only is fine again.
Related: Distributive Conditional Types
JensDll
changed the title
toRefs should not do any ref unwrappingtoRefs should not do any ref unwrapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ToRefstype should not do any ref unwrapping. In #4734 this was also changed forToRefbut was forgotten inToRefs.Sandbox link to reproduction
I also grouped together some of the tests for
toRefandtoRefsinref.test-d.ts.