Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contributing): change node version #5382

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

kuang-lingxi
Copy link
Contributor

I noticed that optional operator(?.) is used in scripts/dev, but it only supports node 14+, so should node 14 be the minimum version limit for developers?

@netlify
Copy link

netlify bot commented Feb 9, 2022

✔️ Deploy Preview for vue-sfc-playground ready!

🔨 Explore the source changes: 25a5bb6

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/620a26dbfea8cd0007b4aa1d

😎 Browse the preview: https://deploy-preview-5382--vue-sfc-playground.netlify.app/

@netlify
Copy link

netlify bot commented Feb 9, 2022

✔️ Deploy Preview for vuejs-coverage ready!

🔨 Explore the source changes: 25a5bb6

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/620a26db03a1610008a5f01f

😎 Browse the preview: https://deploy-preview-5382--vuejs-coverage.netlify.app

@netlify
Copy link

netlify bot commented Feb 9, 2022

✔️ Deploy Preview for vue-next-template-explorer ready!

🔨 Explore the source changes: 25a5bb6

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/620a26db08af070007690660

😎 Browse the preview: https://deploy-preview-5382--vue-next-template-explorer.netlify.app

@Justineo
Copy link
Member

It's actually declared as:

core/package.json

Lines 46 to 48 in 1574edd

"engines": {
"node": ">=16.5.0"
},

@kuang-lingxi
Copy link
Contributor Author

kuang-lingxi commented Feb 14, 2022

Sorry I just noticed this. I just followed the docs before. Wouldn't it be better if the docs could be updated synchronously?

maybe a new pr is clearer. 5422

@kuang-lingxi kuang-lingxi reopened this Feb 14, 2022
@Justineo Justineo merged commit 5898629 into vuejs:main Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants