fix(runtime-core): always hydrate hosited children for HMR #5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
added
❗ p4-important
antfu
changed the title
antfu
changed the title
|
✔️ Deploy Preview for vue-next-template-explorer ready! 🔨 Explore the source changes: f1a6a32 🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/620625b77502d40007195c7e 😎 Browse the preview: https://deploy-preview-5406--vue-next-template-explorer.netlify.app |
7 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix nuxt/framework#5405
fix nuxt/nuxt#11956
In Dev, hoisted nodes are not always "static" as developers might change it with HMR. We shouldn't skip the children's hydration.
Not sure if tests are required in this case