Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): sfc props transform aliasing w/ StringLiteral #5436

Merged
merged 4 commits into from
May 13, 2022

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Feb 16, 2022

close #5425

  • support aliasing w/ StringLiteral
  • refactor __props.xxx to __props['xxx']

@netlify
Copy link

netlify bot commented Feb 16, 2022

✔️ Deploy Preview for vue-sfc-playground ready!

🔨 Explore the source changes: 2389d8cccd9827083230832f0834081329aedeb5

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/620c636c3835ec0007b6fbf5

😎 Browse the preview: https://deploy-preview-5436--vue-sfc-playground.netlify.app/

@netlify
Copy link

netlify bot commented Feb 16, 2022

Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 8dea0dd
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/627dc19096a1390008ac437e

@netlify
Copy link

netlify bot commented Feb 16, 2022

✔️ Deploy Preview for vue-next-template-explorer ready!

🔨 Explore the source changes: 2389d8cccd9827083230832f0834081329aedeb5

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/620c636c77d8b300071abb31

😎 Browse the preview: https://deploy-preview-5436--vue-next-template-explorer.netlify.app

@yyx990803
Copy link
Member

I refactored it to only use bracket notation when necessary. This introduces fewer changes and also fewer bytes in generated code.

@yyx990803 yyx990803 merged commit 242914d into vuejs:main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming destructured props fails in some cases
2 participants