Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-compat): remove test.only #5715

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

cexbrayat
Copy link
Member

A test.onlyhas been introduced in 1612971

cc @LinusBorg

@netlify
Copy link

netlify bot commented Apr 13, 2022

Deploy Preview for vuejs-coverage ready!

Name Link
🔨 Latest commit 5da093a
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/625724df32e686000813ce59
😎 Deploy Preview https://deploy-preview-5715--vuejs-coverage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 13, 2022

Deploy Preview for vue-sfc-playground ready!

Name Link
🔨 Latest commit 5da093a
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/625724dfb700f5000a3cac35
😎 Deploy Preview https://deploy-preview-5715--vue-sfc-playground.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 13, 2022

Deploy Preview for vue-next-template-explorer ready!

Name Link
🔨 Latest commit 5da093a
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/625724df0fbb21000955a0b0
😎 Deploy Preview https://deploy-preview-5715--vue-next-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@LinusBorg
Copy link
Member

Sorry about that.

We need to catch this in CI somehow, too easy to miss.

I'm pretty sure there's a lint rule or jest flag for this ...

@cexbrayat
Copy link
Member Author

No worries

Yeah, there's a lint rule we should add. I'll check it out tomorrow (it's getting late in France). I'll open a PR and ping you

@yyx990803 yyx990803 merged commit 86858a9 into vuejs:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants