-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(runtime-core): delete stale slots which are present but undefined #6484
Merged
yyx990803
merged 4 commits into
vuejs:main
from
KaelWD:fix/delete-defined-undefined-slots
Oct 20, 2023
Merged
fix(runtime-core): delete stale slots which are present but undefined #6484
yyx990803
merged 4 commits into
vuejs:main
from
KaelWD:fix/delete-defined-undefined-slots
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sxzz Will it be merged? |
@KaelWD Thanks for the PR, could you add a test? |
@zhangzhonghe tests updated |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
sxzz
added
ready for review
This PR requires more reviews
and removed
need test
The PR has missing test cases.
labels
Sep 1, 2023
sxzz
force-pushed
the
fix/delete-defined-undefined-slots
branch
from
September 1, 2023 17:34
fa25bff
to
47e2f6f
Compare
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
Size ReportBundles
Usages
|
baiwusanyu-c
approved these changes
Sep 1, 2023
sxzz
approved these changes
Sep 2, 2023
CI failed. Could you please format your files? |
That adds a bunch of other changes in unrelated files. |
sxzz
approved these changes
Sep 12, 2023
sxzz
added
ready to merge
The PR is ready to be merged.
❗ p4-important
Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf.
and removed
ready for review
This PR requires more reviews
labels
Sep 19, 2023
haoqunjiang
approved these changes
Oct 19, 2023
edison1105
approved these changes
Oct 20, 2023
yyx990803
pushed a commit
that referenced
this pull request
Oct 21, 2023
lumozx
pushed a commit
to lumozx/core
that referenced
this pull request
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
❗ p4-important
Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf.
ready to merge
The PR is ready to be merged.
scope: slots
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9109
If
slots.loader
becomes undefined,slots.default
in LoaderSlot was still the old value because the key is still present