Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): remove number type of provide #6497

Closed
wants to merge 1 commit into from
Closed

fix(types): remove number type of provide #6497

wants to merge 1 commit into from

Conversation

xiaoxiangmoe
Copy link
Contributor

@xiaoxiangmoe xiaoxiangmoe commented Aug 18, 2022 •
edited by sxzz
Loading

see #2616 (comment)

closes #9439

@netlify
Copy link

netlify bot commented Aug 18, 2022

❌ Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit c7c5148
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/62fe1ece13f3b400089cbb1f

@xiaoxiangmoe xiaoxiangmoe mentioned this pull request Sep 20, 2022
Open
13 tasks
@sxzz sxzz added the ready to merge The PR is ready to be merged. label Jun 12, 2023
@sxzz sxzz removed the ready to merge The PR is ready to be merged. label Jun 12, 2023
sxzz
sxzz requested changes Jun 12, 2023
View reviewed changes
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have already supported the number type key. To avoid any breaking changes, I suggest that we keep it.

@pikax
Copy link
Member

pikax commented Oct 20, 2023

Closing this based on @sxzz comment.

Numbers work as expected, they are converted to string internally
playground

@pikax pikax closed this Oct 20, 2023
@sxzz sxzz reopened this Dec 2, 2023
@sxzz sxzz changed the base branch from main to minor December 2, 2023 14:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.7 kB 33 kB 29.8 kB
vue.global.prod.js 133 kB 49.8 kB 44.6 kB

Usages

Name Size Gzip Brotli
createApp 48.2 kB 19 kB 17.4 kB
createSSRApp 51.5 kB 20.3 kB 18.5 kB
defineCustomElement 50.6 kB 19.7 kB 18 kB
overall 61.6 kB 23.8 kB 21.7 kB

@sxzz sxzz linked an issue Dec 2, 2023 that may be closed by this pull request
Types inject does not support number argument #9439
Open
@sxzz
Copy link
Member

sxzz commented Dec 2, 2023

Reopen this since we have a discussion on #9439

@edison1105 edison1105 deleted the branch vuejs:minor October 21, 2024 07:37
@edison1105 edison1105 closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
need discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Types inject does not support number argument
4 participants
@xiaoxiangmoe @pikax @sxzz @edison1105