-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runtime-dom): Apply nested styling in custom elements (fix #4662) #6610
Conversation
❌ Deploy Preview for vue-sfc-playground failed.
|
This issue is a blocker for practically any custom elements development using Vue. What could be done to help fixing / merging this? Original issue is 1 year old at this point. |
It would be great if this PR got some attention. It would fix a lot of issues for us. |
Hello @LinusBorg , Could you please evaluate this PR and see if this could be a valid fix for #4662 issue? Thank you so much, |
Hello @LinusBorg @yyx990803, Could you please evaluate this PR and see if this could be a valid fix for #4662 issue? Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works with Vite build & HMR. Passes all tests I threw at it, including all the one's from the alternative PR here.
edit: Looking back, I'm having trouble replicating my Vite/HMR results. Might've used a direct vue.esm-browser.js
import accidentally.
superseded by #11517 |
Summary
This is an alternative to #4309 fixing issue #4662. Compared to #4309 this should fix a few additional things:
<script setup>
by having compiler-sfc generate the components option.Changes
compiler-sfc/compileScript.ts
<script setup>
block.runtime-core/apiCustomElement.ts