fix(reactivity): enable trigger when use str to set length of arr #6810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
approved these changes
Oct 3, 2022
|
That's a strange behavior of JS, TIL. 😅 |
sxzz
approved these changes
Oct 4, 2022
|
A new user left a comment. This user must be approved by a Netlify team owner before comments can be displayed. |
chrislone
pushed a commit
to chrislone/core
that referenced
this pull request
Feb 4, 2023
…ejs#6810) Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
zhangzhonghe
pushed a commit
to zhangzhonghe/core
that referenced
this pull request
Apr 12, 2023
…ejs#6810) Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
js allows use string to set length of array.
The original code uses an implicit conversion that requires newValue to be a number as key's type is string. If newValue is also a string, string comparison are performed instead of number comparison. The string comparison is lexicographical order, so "10"< "2", causing the length to be set to 2 but watch element at 10 will not be triggered