Feat/custom element #7971
Closed
Feat/custom element #7971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 11, 2023 21:25
…core into feat/custom-element
| @@ -402,7 +402,7 @@ function updateCssVars(vnode: VNode) { | |||
| const ctx = vnode.ctx | |||
| if (ctx && ctx.ut) { | |||
| let node = (vnode.children as VNode[])[0].el! | |||
| while (node !== vnode.targetAnchor) { | |||
| while (node && node !== vnode.targetAnchor) { | |||
There was a problem hiding this comment.
This modification should have nothing to do with pr, I think this modification should be avoided
| @@ -141,7 +141,7 @@ export function defineCustomElement( | |||
| class VueCustomElement extends VueElement { | |||
| static def = Comp | |||
| constructor(initialProps?: Record<string, any>) { | |||
| super(Comp, initialProps, hydrate) | |||
| super(Comp, initialProps, hydrate, options.shadowRoot) | |||
There was a problem hiding this comment.
If this options.shadowRoot is passed directly to sfc and uses script setup, how will it be set?
There was a problem hiding this comment.
You can use this reference configuration method, use a config as a parameter to pass in the control #4404 , and if possible, I would like to add this pr change idea to unplugin-vue-ce
There was a problem hiding this comment.
Thank you very much for your interest in this PR. I will seriously consider your suggestion, and I will think further about this PR. Thank!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat #7968