fix(runtime-core): don't attempt to remove null fragments (fix #7966) #8001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jazcash
changed the title
|
Very similar to #5342. |
Jazcash
changed the title
|
I wonder whether this should be closed in favour of #9392? |
edison1105
reviewed
Aug 27, 2024
| @@ -2211,7 +2211,7 @@ function baseCreateRenderer( | |||
| // For fragments, directly remove all contained DOM nodes. | |||
| // (fragment child nodes cannot have transition) | |||
| let next | |||
| while (cur !== end) { | |||
| while (cur && cur !== end) { | |||
There was a problem hiding this comment.
Thanks for this PR, but this is not the proper fix because fragment child nodes can not be undefined. the underlying cause see
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #7966, the vue renderer crashes when using Teleport in combination with Transition and Suspense. I don't really know anything about vue core, but this simple change seems to fix the issue without breaking anything else. All unit tests pass still too.