Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): merge props and emits strategy #8052

Merged
merged 9 commits into from
Apr 10, 2023

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented Apr 8, 2023

Fixes: #7989

@himself65 himself65 changed the title fix(runtime-core): merge emits strategy fix(runtime-core): merge props and emits strategy Apr 8, 2023
return [...new Set([...to, ...from])]
}
return extend(
Object.create(null),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is added to avoid mutating raw user objects

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like the same problem that's currently occurring in the devtools when inspecting components with mixins: https://github.com/vuejs/devtools/issues/2037

@yyx990803 yyx990803 merged commit c94ef02 into vuejs:main Apr 10, 2023
@himself65 himself65 deleted the fix-merge-emits branch April 11, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong merging of props and emits definitions from mixins
3 participants