Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add __NO_SIDE_EFFECTS__ comments #9053

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Commits on Oct 22, 2023

  1. perf: add __NO_SIDE_EFFECTS__ comment

    chenfan0 authored and sxzz committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    a2a91b7 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Configuration menu
    Copy the full SHA
    c548b71 View commit details
    Browse the repository at this point in the history
  2. chore: remove __NO_SIDE_EFFECTS__ comment from createInstrumentatio…

    …nGetter
    
    Because:
    1. All references to this function have already been annotated with `__PURE__`;
    2. It's not exported.
    
    Therefore, adding `__NO_SIDE_EFFECTS__` does not reduce the bundle size.
    
    Moreover, somehow, when bundling `runtime-dom.global.prod.js`, Rollup does not delete this comment even though it's not exported at all, so it even increases the bundle size a bit.
    haoqunjiang authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    9f1d109 View commit details
    Browse the repository at this point in the history