refactor(reactivity): add instance check for effect

[chenfan0]

No description provided.

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	85.9 kB (+14 B)	32.6 kB (+4 B)	29.5 kB (+17 B)
vue.global.prod.js	132 kB (+14 B)	49.3 kB (+4 B)	44.4 kB (+48 B)

Usages

Name	Size	Gzip	Brotli
createApp	47.9 kB	18.8 kB	17.2 kB
createSSRApp	50.6 kB	19.9 kB	18.2 kB
defineCustomElement	50.3 kB	19.6 kB	17.9 kB
overall	61.2 kB	23.7 kB	21.6 kB

[sxzz]

Could you please provide more info about your PR? Bugfixes or performance enhancement?

[chenfan0]

Could you please provide more info about your PR? Bugfixes or performance enhancement?

When the fn passed by the user contains the effect attribute, fn will be assigned the value fn.effect.fn. However, the existence of theeffect attribute in the fn does not necessarily mean that the effect attribute has the fn attribute. If fn is assigned the value fn.effect.fn as long as the passed fn has the effect attribute, then when the subsequent trigger is triggered, an error that fn is not a function will be reported.

const o = ref(1)
const fn = () => { o.value }
fn.effect = true
effect(fn)
o.value++  // error: fn is not a function

[sxzz]

Could you please provide a reproduction?

[chenfan0]

Could you please provide a reproduction?
https://play.vuejs.org/#eNp9kUFPAjEQhf/KpBeWsFlQbgRI1HDQgxrl2MtmmWKx2zbtFEnI/ndndwVNJNw6772ZftMexZ33xT6hmIl5rIL2BBEp+aW0uvYuEBwhoMoBlcKKoAEVXA0DbhlIWzkbCRws2kx2MzwpyrKUDWGxhKO0AK7YlyahtI20yhY/sxZAoRX7MlOW+6Xl69e6Rpco+z9hNOIZOdxOJhMOz8c9MsNyQVh7UxJyNR+fC5ELikyl9LbYRWd50W6gFJWrvTYYXjxpppZi1l/VeqUx7uup01rG/KRXH1h9XtB38dBqUrwGjBj2KMXZozJskXp79f6MBz6fzdptkuH0FfMNozOpZexj98luGPtPrqN97L5L2+06rg6ENp6W6h8ZoOnyUvDXPVxZ/Rd3Wky7Pn5y0XwDZky2zg==

[sxzz]

/ecosystem-ci run

[vue-bot]

📝 Ran ecosystem CI: Open

suite	result
nuxt	✅ success
pinia	✅ success
quasar	✅ success
router	✅ success
test-utils	✅ success
vant	✅ success
vite-plugin-vue	✅ success
vitepress	✅ success
vue-i18n	✅ success
vue-macros	❌ failure
vuetify	✅ success
vueuse	✅ success
vue-simple-compiler	✅ success

[sxzz]

It's a not bad fix, but maybe we can make effect property as a symbol in the future. We can have more discussion.

• symbol?
  • breaking changes?