fix(types): inference for generic object types #9418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxzz
reviewed
Oct 19, 2023
Size ReportBundles
Usages
|
pikax
reviewed
Nov 3, 2023
Comment on lines
+124
to
+137
| : [T] extends [{ type: infer U; default: infer D }] | ||
| ? [T] extends [PropOptions<infer V, infer E>] | ||
| ? V | ||
| : D | ||
| : [T] extends [{ type: infer U }] | ||
| ? [T] extends [PropOptions<infer V>] | ||
| ? V | ||
| : U | ||
| : [T] extends [{ default: infer U }] | ||
| ? [T] extends [PropOptions<infer V, infer D>] | ||
| ? D | ||
| : U | ||
| : [T] extends [PropType<infer V>] | ||
| ? V |
There was a problem hiding this comment.
there's a few infers not being used can you remove any infers that are not being used?
There was a problem hiding this comment.
you're right, will do
|
Closing because #9652 has a better solution. #9652 (review) is going to be hard though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one fixes
Possibly related:
propslanguage-tools#2192 (comment)props#8144I've used this rather verbose notation because TypeScript doesn't let us assume anything (unknown extends T etc.) about the generic type
T. Not sure if it's the best way to work around this limitation - let me know if you have a better idea.