Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expand defaultAssetUrlOptions #9894

Open
wants to merge 5 commits into
base: minor
Choose a base branch
from
Open

feat: expand defaultAssetUrlOptions #9894

wants to merge 5 commits into from

Conversation

rotu
Copy link
Contributor

@rotu rotu commented Dec 22, 2023

Expanded defaultAssetUrlOptions to include other asset-linking attributes

Expand defaultAssetUrlOptions to include other asset-linking html attributes
@rotu
Copy link
Contributor Author

rotu commented Dec 22, 2023

It seems odd to me that the <audio> element was omitted even though it was present in vue 2.

I don't see a reason why the attributes added in this PR were omitted in the first place. If there's a reason or a potential drawback to this change, I'd like to know!

Copy link

github-actions bot commented Dec 23, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 99 kB 37.5 kB 33.8 kB
vue.global.prod.js 157 kB 57.3 kB 51 kB

Usages

Name Size Gzip Brotli
createApp 54.2 kB 21 kB 19.1 kB
createSSRApp 58.1 kB 22.6 kB 20.6 kB
defineCustomElement 58.8 kB 22.5 kB 20.5 kB
overall 67.8 kB 26 kB 23.7 kB

Copy link

codspeed-hq bot commented Dec 23, 2023

CodSpeed Performance Report

Merging #9894 will not alter performance

Comparing rotu:patch-2 (d521a45) with main (a8d0b1b)

Summary

✅ 53 untouched benchmarks

@haoqunjiang haoqunjiang added scope: sfc 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Dec 29, 2023
@haoqunjiang haoqunjiang added the ready for review This PR requires more reviews label Feb 19, 2024
@haoqunjiang haoqunjiang changed the title Expand defaultAssetUrlOptions feat: expand defaultAssetUrlOptions Mar 15, 2024
@skirtles-code
Copy link
Contributor

skirtles-code commented Apr 17, 2024

I believe this would make #7914 redundant.

A couple of places that might also need updating if this is merged:

Should this change target minor? It seems plausible it'll cause some builds to fail, as plain strings will suddenly be transformed into imports.

@haoqunjiang haoqunjiang added ready to merge The PR is ready to be merged. version: minor and removed ready for review This PR requires more reviews labels May 27, 2024
@yyx990803 yyx990803 changed the base branch from main to minor May 30, 2024 10:28
@edison1105 edison1105 deleted the branch vuejs:minor October 21, 2024 07:37
@edison1105 edison1105 closed this Oct 21, 2024
@edison1105 edison1105 reopened this Oct 21, 2024
Copy link

pkg-pr-new bot commented Oct 21, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@9894

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@9894

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@9894

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@9894

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@9894

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@9894

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@9894

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@9894

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@9894

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@9894

vue

pnpm add https://pkg.pr.new/vue@9894

commit: aef82f4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: sfc version: minor
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants