Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config/typescript): pass build arguments to build-only command #338

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

wsehl
Copy link
Contributor

@wsehl wsehl commented Sep 7, 2023

I was configuring builds with different modes and couldn't run yarn build --mode preview as I would do normally with simple vite build in my "build" script because of ERROR: Invalid Option: --mode

Had to spend some time figuring this out, guess it may be a helpfull addition that will prevent someone from getting a similar issue

@wsehl wsehl changed the title feat: pass build arguments to build-only command fix: pass build arguments to build-only command Sep 7, 2023
@wsehl wsehl changed the title fix: pass build arguments to build-only command fix(config/typescript): pass build arguments to build-only command Sep 7, 2023
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is indeed very helpful!

@haoqunjiang haoqunjiang merged commit 2902e49 into vuejs:main Sep 14, 2023
ghost pushed a commit to stanislavmihaylov/vue-bootstrap that referenced this pull request Oct 4, 2023
* chore(deps): update dependency lint-staged to v14 (vuejs#329)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency chromedriver to v115 (vuejs#324)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (vuejs#323)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: add npm and node badge (vuejs#330)

* fix: remove `transformMode` from vitest config

It's no longer needed in vitest 0.34:

> By default, tests with `jsdom` or `happy-dom` use `web` transform mode

https://github.com/vitest-dev/vitest/releases/tag/v0.34.0

* chore: import both `mergeConfig` and `defineConfig` from `vitest/config`

With the typing fix in Vitest 0.34, it is again possible to use
`defineConfig` and `mergeConfig` from the `vitest` package.

* feat: add VSCode extension recommendations (vuejs#325)

* 3.7.3

* chore: update snapshot

* chore: add `rel="noopener"` to the link to `Cypress Component Testing` (vuejs#333)

* chore(deps): update all non-major dependencies (vuejs#331)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency chromedriver to v116 (vuejs#332)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency cypress to v13 (vuejs#336)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/checkout action to v4 (vuejs#340)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (vuejs#339)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: add playground directory to prettierignore

The code is generated so it makes no sense to format it.

* style: format

* chore: dependency maintenance

* feat: replace npm-run-all with npm-run-all2

https://www.npmjs.com/package/npm-run-all2

It is a maintained fork of npm-run-all, which is not maintained anymore.
Both maintainers of the fork also maintain some other popular packages,
so I consider it a safe replacement.

Another popular alternative is [concurrently](https://www.npmjs.com/package/concurrently).
But [its size](https://packagephobia.com/result?p=concurrently@8.2.1) is too big,
I think it would be an overkill.

Closes vuejs#306

* fix(config/typescript): pass build arguments to build-only command (vuejs#338)

* 3.7.4

* chore: update snapshot

* chore: don't ignore zx updates

Now we are in the same supported Node.js version range as zx,
we can safely upgrade it.

* chore: also check for typescript updates with renovate

* feat: replace npm-run-all with npm-run-all2 (vuejs#343)

* chore(deps): update all non-major dependencies (vuejs#344)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency typescript to ~5.2.0 (vuejs#345)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency chromedriver to v117 (vuejs#346)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* 3.7.5

* chore: update snapshot

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: btea <2356281422@qq.com>
Co-authored-by: Haoqun Jiang <haoqunjiang@gmail.com>
Co-authored-by: zhhbstudio <zhhb@zhhb.studio>
Co-authored-by: 汪心禾 <wangxinhe06@gmail.com>
Co-authored-by: Alex <widesehl@gmail.com>
Co-authored-by: Cédric Exbrayat <cexbrayat@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants