feat: i18n solution for prompts messages #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ci test is blocked because of this: |
haoqunjiang
requested changes
Sep 27, 2023
There was a problem hiding this comment.
Thanks! I've been thinking about this feature for a while.
However, I don't think it should be an additional option. Many people don't wanna bother selecting one at all.
Please make it implicit by reading the user's language setting from the environment variables.
No problem, already updated. Is there anything that needs improvement? |
haoqunjiang
requested changes
Oct 9, 2023
haoqunjiang
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward i18n solution for prompts messages