Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use vitest to make unitest #377

Merged
merged 27 commits into from
Nov 25, 2023
Merged

feat: use vitest to make unitest #377

merged 27 commits into from
Nov 25, 2023

Conversation

CoolPlayLin
Copy link
Contributor

@CoolPlayLin CoolPlayLin commented Nov 12, 2023 •
edited
Loading

cexbrayat
cexbrayat requested changes Nov 12, 2023
View reviewed changes
__test__/getCommand.spec.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
vitest.config.ts Outdated Show resolved Hide resolved
vitest.config.ts Outdated Show resolved Hide resolved
vitest.config.ts Outdated Show resolved Hide resolved
@CoolPlayLin CoolPlayLin marked this pull request as ready for review November 18, 2023 10:10
cexbrayat
cexbrayat requested changes Nov 20, 2023
View reviewed changes
__test__/getCommand.spec.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
__test__/locale.spec.ts Outdated Show resolved Hide resolved
cexbrayat
cexbrayat requested changes Nov 25, 2023
View reviewed changes
Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, just a few names to change and we'll be OK to merge

__test__/getCommand.spec.ts Outdated Show resolved Hide resolved
__test__/getCommand.spec.ts Outdated Show resolved Hide resolved
__test__/getCommand.spec.ts Outdated Show resolved Hide resolved
__test__/getCommand.spec.ts Outdated Show resolved Hide resolved
__test__/getCommand.spec.ts Outdated Show resolved Hide resolved
__test__/sortDependencies.spec.ts Outdated Show resolved Hide resolved
utils/getLanguage.ts Outdated Show resolved Hide resolved
__test__/sortDependencies.spec.ts Outdated Show resolved Hide resolved
__test__/sortDependencies.spec.ts Outdated Show resolved Hide resolved
@CoolPlayLin
🐛 fix: resolve suggestions in code reviews
ad687fb 
delete unnecessary empty line in getCommand.spec.ts
delete unnecessary tests
rename some tests
@CoolPlayLin
🐛 fix: delete unncessary change
ab7bb79
@CoolPlayLin CoolPlayLin reopened this Nov 25, 2023
cexbrayat
cexbrayat approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the PR @CoolPlayLin 👍

@cexbrayat
Copy link
Member

Oh it looks like the PR needs to be rebased on main. Can you do that please?

@CoolPlayLin
Copy link
Contributor Author

CoolPlayLin commented Nov 25, 2023 •
edited
Loading

done @cexbrayat

@cexbrayat cexbrayat merged commit 8b6c2cd into vuejs:main Nov 25, 2023
101 checks passed
@CoolPlayLin CoolPlayLin deleted the CoolPlayLin/vitest branch November 25, 2023 09:57
@CoolPlayLin
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cexbrayat cexbrayat cexbrayat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use vitest to make unittest
2 participants
@CoolPlayLin @cexbrayat