Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use type=module in nightwatch projects #404

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

cexbrayat
Copy link
Member

nightwatch v3.3.4 fixed nightwatchjs/nightwatch#3959

I removed the custom assertions and commands, as they don't work out-of-the-box, they are not used in the generated tests, and they bring little value compared to the official nightwatch documentation

nightwatch v3.3.4 fixed nightwatchjs/nightwatch#3959

I removed the custom assertions and commands, as they don't work out-of-the-box, they are not used in the generated tests, and they bring little value compared to the official nightwatch documentation
@garg3133
Copy link

@cexbrayat Just curious what you mean by "they don't work out-of-the-box".

@cexbrayat
Copy link
Member Author

The JS version needs to use CJS files whereas the TS version needs to use TS files, and for whatever reason, it failed in some combinations of the generated projects (typescript-jsx-nightwatch if I remember correctly). As the custom assertions are not used in the generated tests, I preferred removing them instead of figuring out what we should do to make every combination work. I think people interested in Nightwatch won't have any trouble figuring out how to add custom assertions and commands if they need them.

@haoqunjiang haoqunjiang merged commit 94e9aae into vuejs:main Dec 13, 2023
101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type=module and typescript config
3 participants