Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: explicitly set tsBuildInfoFile in tsconfig.*.json files #409

Merged
merged 2 commits into from
Dec 24, 2023
Merged

chore: explicitly set tsBuildInfoFile in tsconfig.*.json files #409

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a317bf1
chore: explicitly set tsBuildInfoFile in tsconfig.*.json files
haoqunjiang Dec 20, 2023
2a51e7c
chore: keep file name pattern consistent [skip ci]
haoqunjiang Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion template/tsconfig/base/tsconfig.app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"exclude": ["src/**/__tests__/*"],
"compilerOptions": {
"composite": true,
"noEmit": true,
"tsBuildInfoFile": "./node_modules/.tmp/tsconfig.app.tsbuildinfo",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: empty line should be remove? Here and in other configs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to distinguish the emitting-related options from other options… The empty lines would make more sense once we add more detailed explanations in the configs.

"baseUrl": ".",
"paths": {
"@/*": ["./src/*"]
Expand Down
2 changes: 2 additions & 0 deletions template/tsconfig/base/tsconfig.node.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
"compilerOptions": {
"composite": true,
"noEmit": true,
"tsBuildInfoFile": "./node_modules/.tmp/tsconfig.node.tsbuildinfo",

"module": "ESNext",
"moduleResolution": "Bundler",
"types": ["node"]
Expand Down
3 changes: 2 additions & 1 deletion template/tsconfig/cypress-ct/tsconfig.cypress-ct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
],
"exclude": [],
"compilerOptions": {
"composite": true
"composite": true,
"tsBuildInfoFile": "./node_modules/.tmp/tsconfig.cypress-ct.tsbuildinfo"
}
}
3 changes: 2 additions & 1 deletion template/tsconfig/nightwatch-ct/tsconfig.app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"exclude": ["src/**/__tests__/*"],
"compilerOptions": {
"composite": true,
"noEmit": true,
"tsBuildInfoFile": "./node_modules/.tmp/tsconfig.app.tsbuildinfo",

"baseUrl": ".",
"paths": {
"@/*": ["./src/*"]
Expand Down
6 changes: 4 additions & 2 deletions template/tsconfig/nightwatch/nightwatch/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"compilerOptions": {
"composite": true,
"noEmit": true,
"tsBuildInfoFile": "../node_modules/.tmp/nightwatch.tsbuildinfo",
haoqunjiang marked this conversation as resolved.
Show resolved Hide resolved

"target": "ESNext",
"module": "commonjs",
"moduleResolution": "node",
"composite": true,
"noEmit": true,
"rootDir": "../",
"lib": ["ESNext", "dom"],
"types": ["nightwatch"]
Expand Down
2 changes: 2 additions & 0 deletions template/tsconfig/vitest/tsconfig.vitest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
"exclude": [],
"compilerOptions": {
"composite": true,
"tsBuildInfoFile": "./node_modules/.tmp/tsconfig.vitest.tsbuildinfo",

"lib": [],
"types": ["node", "jsdom"]
}
Expand Down