-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add vscode config for ESLint #467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except for scripts/snapshot.mjs
This is going to make a lot of new snapshots
I think cexbrayat will provide better feedback for scripts/snapshot.mjs (for reference, #460 (comment)).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the snapshot generation, LGTM, thanks for the PR.
scripts/snapshot.mjs
Outdated
] | ||
const featureFlagsDenylist = [ | ||
['eslint', 'eslint-with-prettier'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes to this file should be removed, as this is going to generate a lot of new snapshots (that's why they aren't generated at the moment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved eslint and eslint-with-prettier as separate features based on #460 (comment).
@@ -120,6 +120,7 @@ async function init() { | |||
argv.nightwatch ?? | |||
argv.playwright ?? | |||
argv.eslint ?? | |||
argv['eslint-with-prettier'] ?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍
Description
If the user picks ESLint, then suggest the ESLint .vscode extension, and add the settings.
settings.json
extensions.json
Related Issue
#466
Notes for Reviewers