Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run to build command when using bun #615

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

Hornwitser
Copy link
Contributor

Description

If the package manager is bun and the command is build generate 'bun run build' as the command to invoke the build script instead of the built-in 'bun build' command.

Resolves #614

@Hornwitser Hornwitser force-pushed the bun-run-build branch 2 times, most recently from 65d53d2 to 96eb7ae Compare November 17, 2024 16:22
@Hornwitser
Copy link
Contributor Author

I have no idea how to fix this error thrown by the CI

> eslint . --fix "--no-fix" "--max-warnings=0"


Oops! Something went wrong! :(

ESLint: 9.15.0

TypeError: Error while loading rule '@typescript-eslint/no-unused-expressions': Cannot read properties of undefined (reading 'allowShortCircuit')
Occurred while linting /home/runner/work/create-vue/sample-project/cypress/e2e/example.cy.ts
    at Object.create (/home/runner/work/create-vue/sample-project/node_modules/.pnpm/eslint@9.15.0/node_modules/eslint/lib/rules/no-unused-expressions.js:75:[13](https://github.com/vuejs/create-vue/actions/runs/11880418479/job/33103554960?pr=615#step:19:14))
    at create (/home/runner/work/create-vue/sample-project/node_modules/.pnpm/@typescript-eslint+eslint-plugin@8.[14](https://github.com/vuejs/create-vue/actions/runs/11880418479/job/33103554960?pr=615#step:19:15).0_@typescript-eslint+parser@8.14.0_eslint@9.[15](https://github.com/vuejs/create-vue/actions/runs/11880418479/job/33103554960?pr=615#step:19:16).0_typesc_u2crwq53uno6k5fweinf7nowby/node_modules/@typescript-eslint/eslint-plugin/dist/rules/no-unused-expressions.js:28:32)
    at Object.create (/home/runner/work/create-vue/sample-project/node_modules/.pnpm/@typescript-eslint+utils@8.14.0_eslint@9.15.0_typescript@5.6.3/node_modules/@typescript-eslint/utils/dist/eslint-utils/RuleCreator.js:31:20)
    at createRuleListeners (/home/runner/work/create-vue/sample-project/node_modules/.pnpm/eslint@9.15.0/node_modules/eslint/lib/linter/linter.js:944:21)
    at /home/runner/work/create-vue/sample-project/node_modules/.pnpm/eslint@9.15.0/node_modules/eslint/lib/linter/linter.js:1082:84
    at Array.forEach (<anonymous>)
    at runRules (/home/runner/work/create-vue/sample-project/node_modules/.pnpm/eslint@9.15.0/node_modules/eslint/lib/linter/linter.js:1013:34)
    at #flatVerifyWithoutProcessors (/home/runner/work/create-vue/sample-project/node_modules/.pnpm/eslint@9.15.0/node_modules/eslint/lib/linter/linter.js:[19](https://github.com/vuejs/create-vue/actions/runs/11880418479/job/33103554960?pr=615#step:19:20)11:31)
    at Linter._verifyWithFlatConfigArrayAndWithoutProcessors (/home/runner/work/create-vue/sample-project/node_modules/.pnpm/eslint@9.15.0/node_modules/eslint/lib/linter/linter.js:1993:49)
    at Linter._verifyWithFlatConfigArray (/home/runner/work/create-vue/sample-project/node_modules/.pnpm/eslint@9.15.0/node_modules/eslint/lib/linter/linter.js:[20](https://github.com/vuejs/create-vue/actions/runs/11880418479/job/33103554960?pr=615#step:19:21)82:21)
 ELIFECYCLE  Command failed with exit code 2.
Error: Process completed with exit code 2.

@haoqunjiang
Copy link
Member

No worries, the error will be fixed in the next release of typescript-eslint: typescript-eslint/typescript-eslint#10338

Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

Can you rebase your branch, please? The CI should be green now

If the package manager is bun and the command is build generate 'bun run
build' as the command to invoke the build script instead of the built-in
'bun build' command.
@cexbrayat cexbrayat merged commit 23c29ee into vuejs:main Nov 19, 2024
101 checks passed
@Hornwitser Hornwitser deleted the bun-run-build branch November 20, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build command in generated README.md does not work with Bun
3 participants