Toggle component tree recursively with alt key pressed #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
requested changes
Feb 19, 2017
| @@ -14,7 +14,7 @@ | |||
| <!-- arrow wrapper for better hit box --> | |||
| <span class="arrow-wrapper" | |||
| v-if="instance.children.length" | |||
| @click.stop="toggle()"> | |||
| @click.stop="toggle($event)"> | |||
There was a problem hiding this comment.
the event is passed implicitly. You can just remove the ()
| this.$store.dispatch('components/toggleInstance', { | ||
| instance: this.instance, | ||
| expanded: val, | ||
| recursive: recursive |
| @@ -30,8 +30,25 @@ const mutations = { | |||
| } | |||
| } | |||
|
|
|||
| const actions = { | |||
| toggleInstance ({commit, dispatch}, {instance, expanded, recursive}) { | |||
| commit('TOGGLE_INSTANCE', {id: instance.id, expanded: expanded}) | |||
| instance.children.forEach((child) => { | ||
| dispatch('toggleInstance', { | ||
| instance: child, | ||
| expanded: expanded, |
|
@posva I updated to conform to your requests and force pushed to not pollute history with unnecessary commits :) hope it's all okay now |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once application grows, it becomes irritating to have to click component by component to expand the tree. Following Chrome's convention (as pointed by @kaleb) I added support for toggling the tree recursively if 'alt' key is pressed during toggle.
I also think it's high time for 'Settings' tab to be able to customize Devtool's behaviour. E.g. for example I'd like to start with component tree fully expanded but I guess I'll just submit Feature request