Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter events by instance name too + Events tests #413

Merged
merged 3 commits into from
Jan 12, 2018
Merged

Filter events by instance name too + Events tests #413

merged 3 commits into from
Jan 12, 2018

Conversation

eigan
Copy link
Contributor

@eigan eigan commented Sep 15, 2017

  • Not case insensitive (components tab is)
  • No idea what happens if instanceName is null or undefined

@Akryum Akryum requested review from yyx990803 and posva December 22, 2017 15:55
@Akryum
Copy link
Member

Akryum commented Dec 22, 2017

Tested and working great - I have added some e2e tests for the Events tab.

@Akryum Akryum changed the title Filter events by instance name too Filter events by instance name too + Events tests Dec 22, 2017
posva
posva approved these changes Dec 23, 2017
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have used id instead of classes on the buttons that are used for tests but looks good otherwise.
On a side note, I think we could add some search algorithm to make it more permissive

@Akryum Akryum mentioned this pull request Dec 31, 2017
Merged
@michalsnik michalsnik added this to the 🎄Holiday Update milestone Jan 3, 2018
@yyx990803 yyx990803 merged commit a8e6f18 into vuejs:master Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

@Akryum Akryum Akryum approved these changes

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
🎄Holiday Update
Development

Successfully merging this pull request may close these issues.
5 participants
@eigan @Akryum @posva @yyx990803 @michalsnik