Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace node-sass with sass #768

Merged
merged 1 commit into from
Jan 1, 2021
Merged

chore: replace node-sass with sass #768

merged 1 commit into from
Jan 1, 2021

Conversation

Xenonym
Copy link
Contributor

@Xenonym Xenonym commented Dec 30, 2020

Description of Problem

node-sass is used to compile Sass styles. However, it has been deprecated.

Proposed Solution

Replace node-sass with sass as recommended:

  • We recommend all existing LibSass users make plans to eventually move onto Dart Sass, and that all Sass libraries make plans to eventually drop support for LibSass.

[...]

If you’re a user of Node Sass, migrating to Dart Sass is straightforward: just replace node-sass in your package.json file with sass. Both packages expose the same JavaScript API.

Additional Information

@Xenonym
chore: replace node-sass with sass
f9a74d3 
Since node-sass has been deprecated [1], we should replace it with sass
instead.

[1]: https://sass-lang.com/blog/libsass-is-deprecated
skirtles-code
skirtles-code approved these changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out on my laptop and everything seemed to install/build/render just as it did previously.

This seems like a good change to me.

@NataliaTepluhina NataliaTepluhina merged commit 4883478 into vuejs:master Jan 1, 2021
@Xenonym Xenonym deleted the chore/replace-node-sass branch January 1, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirtles-code skirtles-code skirtles-code approved these changes

@NataliaTepluhina NataliaTepluhina NataliaTepluhina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xenonym @NataliaTepluhina @skirtles-code