Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vue/no-restricted-component-names rule #2210

Merged
merged 7 commits into from
Jun 12, 2023
Merged

Add vue/no-restricted-component-names rule #2210

merged 7 commits into from
Jun 12, 2023

Conversation

ItMaga
Copy link
Contributor

@ItMaga ItMaga commented Jun 9, 2023

closes #2182

I slightly changed the schema format that was proposed in the issue, as in no-restricted-props rule.

FloEdelmann
FloEdelmann requested changes Jun 9, 2023
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I have some comments, see below.

lib/rules/no-restricted-component-names.js Outdated Show resolved Hide resolved
lib/rules/no-restricted-component-names.js Outdated Show resolved Hide resolved
lib/rules/no-restricted-component-names.js Outdated Show resolved Hide resolved
lib/rules/no-restricted-component-names.js Show resolved Hide resolved
@ItMaga ItMaga requested a review from FloEdelmann June 10, 2023 12:52
FloEdelmann
FloEdelmann approved these changes Jun 11, 2023
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! 🙂

@FloEdelmann FloEdelmann requested a review from ota-meshi June 11, 2023 15:13
@ItMaga ItMaga requested a review from ota-meshi June 12, 2023 21:06
ota-meshi
ota-meshi approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit e643d44 into vuejs:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule Proposal: vue/no-restricted-component-names
3 participants
@ItMaga @FloEdelmann @ota-meshi