Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(require-explicit-slots): recognize slot names enclosed in quotes #2397

Merged
merged 4 commits into from
Feb 19, 2024
Merged

fix(require-explicit-slots): recognize slot names enclosed in quotes #2397

merged 4 commits into from
Feb 19, 2024

Conversation

waynzh
Copy link
Member

@waynzh waynzh commented Feb 6, 2024 •
edited by FloEdelmann
Loading

fixes #2391

  1. The update now allows node.key to be a string, supporting both Identifier and Literal types. It also skips over dynamic slot names since slotNameAttr only detects nodes with directive: false.

  2. The memberNode type has been narrowed down to only include TSMethodSignature and TSPropertySignature.

  • foo(): any
  • foo: () => any

@waynzh waynzh changed the title fix: recognize slot names enclosed in quotes fix(require-explicit-slots): recognize slot names enclosed in quotes Feb 6, 2024
@waynzh @FloEdelmann
Update lib/rules/require-explicit-slots.js
d5c39ed 
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
FloEdelmann
FloEdelmann approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! 🙂

@FloEdelmann FloEdelmann requested a review from ota-meshi February 6, 2024 13:36
ota-meshi
ota-meshi approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit c2451ab into vuejs:master Feb 19, 2024
17 checks passed
@waynzh waynzh mentioned this pull request Mar 5, 2024
Merged
This was referenced Jul 29, 2024
Merged
Open
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

require-explicit-slots does not recognize slot names enclosed in quotes
3 participants
@waynzh @FloEdelmann @ota-meshi