Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn PnP Compatability #3762

Closed
wants to merge 2 commits into from
Closed

Conversation

vantaboard
Copy link

@vantaboard vantaboard commented Nov 30, 2023

Fixes yarnpkg/berry#3123, fixes #918. 🥳

@vantaboard vantaboard changed the title fix(language-service): yarn pnp compat Yarn PnP Compatability Nov 30, 2023
@so1ve
Copy link
Member

so1ve commented Nov 30, 2023

🤔 Should this be fixed in https://github.com/volarjs/volar.js?

@vantaboard
Copy link
Author

🤔 Should this be fixed in https://github.com/volarjs/volar.js?

Hmm. I see what you mean. Let me work on a PR on that front, then. Feel free to close this one.

@bmulholland
Copy link

bmulholland commented Jan 24, 2024

Did #3788 fix this? It closed the linked issue.

@johnsoncodehk
Copy link
Member

Did #3788 fix this? It closed the linked issue.

Yes, this PR makes everything based on the original tsserver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Go to definition doesn't work with Volar Yarn 3 incompatibility
4 participants