-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update readme with neovim lspconfig setup #4134
Conversation
56e4563
to
da22b5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think best would be to avoid things like mason, not every one uses it and those who do know how to adopt configs to it.
There could be an argument made that even lspconfig is something that could be avoided here, but its adoption is so widespread that it's harder to justify it.
Thanks for that PR though!
As not everyone is using mason, it's better to use plain lspconfig
Thanks @gegoune for your recommendations. 💖 |
@RayGuo-ergou but in my nvim config, if i set hybridMode = false, i dont need run tsserver |
Shoot! My bad, it should be the opposite way, thanks so much! |
Very happy to be of help! Thank you for taking initiative here! 🦸 You can ping me when you think it's ready and I can take another look. |
Perhaps we should establish a community for Neovim users in the forum, as we have done in the past. In addition to providing correct configurations, it can also facilitate effective communication. Thanks for that PR though! |
@gegoune Do not if you have received the notification that I have request a review again but just in case. I have updated the docs and should be more clear in my opinion. The config title changed from 'xxx version' to 'Hybrid/none-hybrid'. Would you review it again when you have time 🙇♂️ thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thank you!
Would be nice to see what are pros and cons of each configuration approach, but that's out of scope for this PR and not related to Neovim only.
Thank you for taking your time to make it so easy to understand!
LGTM, thanks everyone! |
Description
The length of this issue continues to increase. I believe that posting the configuration directly in the README would be more straightforward for anyone seeking help.