-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(language-core): document links for classname within :class
#4642
feat(language-core): document links for classname within :class
#4642
Conversation
:class
:class
I think rename support can be left out for now. The current class name rename solution is unreliable due to a upstream issue (volarjs/volar.js#176). |
dcae58c
to
cf96978
Compare
This commit treats repeated class declarations as references to the first class, ensuring synchronization when renaming classes with the same name. This requires ignoring the CSS renaming behavior when using the typescript-semantic renaming feature. Currently, since no interception is implemented, class renaming in the |
Since we have extracted the classnames as much as possible, the logic previously used for renaming support is no longer necessary. |
commit: vue-component-meta
vue-component-type-helpers
@vue/language-core
@vue/language-plugin-pug
@vue/language-server
@vue/language-service
vue-tsc
@vue/typescript-plugin
|
Awesome, thanks! I tested it manually, it would be great if you could add a test case for it. I plan to extract this feature to the language service plugin instead of relying on TS virtual code, which will improve the robustness of this feature. |
resolve #4641