Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-core): handle v-for with v-once correctly #4830

Merged
merged 4 commits into from
Sep 10, 2024
Merged

fix(language-core): handle v-for with v-once correctly #4830

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9441b3a
fix: handle `v-for` with `v-once` correctly
KazariEX Sep 9, 2024
b8f16aa
Update packages/language-core/lib/codegen/template/vFor.ts
KazariEX Sep 9, 2024
b13d4ae
fix: handle cache of `codegenNode`
KazariEX Sep 9, 2024
e1f09d6
chore: update test
zhiyuanzmj Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/language-core/lib/codegen/template/vFor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ export function* generateVFor(
ctx.addLocalVariable(varName);
}
let isFragment = true;
for (const argument of node.codegenNode?.children.arguments ?? []) {
// children is undefined with v-once (#4827)
for (const argument of node.codegenNode?.children?.arguments ?? []) {
KazariEX marked this conversation as resolved.
Show resolved Hide resolved
if (
argument.type === CompilerDOM.NodeTypes.JS_FUNCTION_EXPRESSION
&& argument.returns?.type === CompilerDOM.NodeTypes.VNODE_CALL
Expand Down
3 changes: 3 additions & 0 deletions test-workspace/tsc/passedFixtures/vue3/#4827/main.vue
View file
Open in desktop
zhiyuanzmj marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<template>
<pre v-for="_ in []" v-once></pre>
</template>