Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VueTestUtils 2 API proposal for Vue 3 #161
VueTestUtils 2 API proposal for Vue 3 #161
Changes from 1 commit
d26461c
668866f
65cb0ec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While having everything affecting global things in
global
is perfect, thank you for this, I'm a bit concerned aboutprovide
. From what I understand We have two things in "global":provide
is just providing data forprovide/inject
, and for example providingfoo
inglobal.provide
does not guarantee that my value will be always injected in component somewhere deep in the tree - it could be easily changed byprovide
in some ancestorMaybe it's worth to keep this our of
global
object since its behavior is different?