fix(history): ensure base is normalized in memory history (#1112)

vuejs · Sep 10, 2021 · 198a5bd · 198a5bd
1 parent da7a219
commit 198a5bd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/__tests__/history/memory.spec.ts b/__tests__/history/memory.spec.ts
@@ -185,4 +185,9 @@ describe('Memory history', () => {
     history.go(1, false)
     expect(spy).not.toHaveBeenCalled()
   })
+
+  it('handles a non-empty base', () => {
+    expect(createMemoryHistory('/foo/').base).toBe('/foo')
+    expect(createMemoryHistory('/foo').base).toBe('/foo')
+  })
 })
diff --git a/src/history/memory.ts b/src/history/memory.ts
@@ -6,6 +6,7 @@ import {
   NavigationType,
   NavigationDirection,
   NavigationInformation,
+  normalizeBase,
   createHref,
   HistoryLocation,
 } from './common'
@@ -21,6 +22,7 @@ export function createMemoryHistory(base: string = ''): RouterHistory {
   let listeners: NavigationCallback[] = []
   let queue: HistoryLocation[] = [START]
   let position: number = 0
+  base = normalizeBase(base)
 
   function setLocation(location: HistoryLocation) {
     position++