Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: support dir in meta for pages #2085

Merged
merged 2 commits into from
Jan 7, 2024
Merged

docs: support dir in meta for pages #2085

merged 2 commits into from
Jan 7, 2024

Conversation

Jinjiang
Copy link
Member

Support adding dir in meta like:

---
dir: rtl
---

The demo screenshot

image

So we can control the direction per each page.

Thanks.

/cc @brc-dd

Copy link

netlify bot commented Dec 17, 2023

Deploy Preview for vue-router ready!

Name Link
🔨 Latest commit 4667994
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/659a9f621f60840009978496
😎 Deploy Preview https://deploy-preview-2085--vue-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

posva commented Dec 17, 2023

Shouldn't this be set directly in Vitepress theme 🤔

@Jinjiang
Copy link
Member Author

Yea, I think it's a good idea. Another PR has been created there. :-)

@Jinjiang Jinjiang force-pushed the jinjiang/docs/meta-dir branch from 17e8e7f to 306ca21 Compare January 7, 2024 12:55
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ac7d5c) 90.85% compared to head (4667994) 90.85%.
Report is 7 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2085   +/-   ##
=======================================
  Coverage   90.85%   90.85%           
=======================================
  Files          24       24           
  Lines        1115     1115           
  Branches      347      347           
=======================================
  Hits         1013     1013           
  Misses         63       63           
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jinjiang
Copy link
Member Author

Jinjiang commented Jan 7, 2024

@posva I reset this branch and just bumped the vitepress version. It works as expected from my side. Please take a look. 🙏

@posva posva merged commit 2df32af into main Jan 7, 2024
6 checks passed
@posva posva deleted the jinjiang/docs/meta-dir branch January 7, 2024 14:32
niceplugin added a commit to niceplugin/Vuejs-Router-KO that referenced this pull request Jan 15, 2024
niceplugin added a commit to niceplugin/Vuejs-Router-KO that referenced this pull request Jan 15, 2024
* docs: style error caused by banner (vuejs#2099)

* docs: support dir in meta for pages (vuejs#2085)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants