Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace translation scripts and ui with vitepress-translation-helper #2109

Merged
merged 7 commits into from
Jan 29, 2024

Conversation

Jinjiang
Copy link
Member

I published a dedicated npm package https://www.npmjs.com/package/vitepress-translation-helper

And I updated the npm scripts and contributing page accordingly.

New npm scripts:

  • docs:translation:compare
  • docs:translation:update
  • docs:translation:status

with this new npm package, the workflow is much easier to be cloned to other Vue ecosystem lib.

feel good?

Thanks.

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for vue-router ready!

Name Link
🔨 Latest commit ad28071
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/65b772ba565b5500089404c6
😎 Deploy Preview https://deploy-preview-2109--vue-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2df32af) 90.85% compared to head (2d1751c) 90.85%.
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2109   +/-   ##
=======================================
  Coverage   90.85%   90.85%           
=======================================
  Files          24       24           
  Lines        1115     1115           
  Branches      347      347           
=======================================
  Hits         1013     1013           
  Misses         63       63           
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jinjiang Jinjiang marked this pull request as draft January 11, 2024 15:06
@Jinjiang Jinjiang marked this pull request as ready for review January 11, 2024 23:12
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@posva posva merged commit ad65dc2 into main Jan 29, 2024
6 checks passed
@posva posva deleted the jinjiang/refactor/translation branch January 29, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants