Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(guards): run beforeRouteEnter with app context #2117

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

yozi-developer
Copy link
Contributor

@yozi-developer yozi-developer commented Jan 26, 2024

Fix #2051
Close #2053

The PR is based on the #2053

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit 414c227
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/65b31aab68ba0c0008ab20ac

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva merged commit 6a69696 into vuejs:main Jan 29, 2024
5 checks passed
@yozi-developer yozi-developer deleted the fix/2051-run-guards-in-context branch January 29, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

beforeRouteEnter does not have an injection context if component is not yet loaded
2 participants